Filter unused messages #421
Conversation
mpkorstanje
force-pushed
the
filter-unused-messages
branch
from
bb4bb73 to
11430d5
Compare
Because the message stream simply writes all messages, the report is larger than it needs to be. By filtering out step definitions, hooks and parameter types the report becomes smaller (but not much).
mpkorstanje
force-pushed
the
filter-unused-messages
branch
from
11430d5 to
138ee9a
Compare
| @@ -138,6 +138,10 @@ export class CucumberHtmlStream extends Transform { | |||
| } | |||
|
|
|||
| private writeMessage(envelope: messages.Envelope) { | |||
| if (envelope.stepDefinition || envelope.hook || envelope.parameterType) { | |||
There was a problem hiding this comment.
@davidjgoss in #414 (comment) you said:
Before implementing the specific solution suggested here I think it would make sense to strip out all messages that are not used by the html report.
Agreed. As it stands we can do without:
* `source` * `stepDefinition`
But source is used by react components. Instead I got this set of messages as unused from Cucumber JVM (filesize workaround).
Does this make sense?
There was a problem hiding this comment.
Ah yes, source is currently used, although I am getting rid of that soon in cucumber/react-components#396.
hook is definitely used in the components to look up the name and other details of the defined hook.
But stepDefinition and parameterType can definitely be filtered out for now.
There was a problem hiding this comment.
Okay. I'll wait for cucumber/react-components#396 then.
⚡️ What's your motivation?
Because the message stream simply writes all messages, the report is
larger than it needs to be. By filtering out step definitions, hooks and
parameter types the report becomes smaller (but not much).
Closes: #414
🏷️ What kind of change is this?
📋 Checklist: