Add a release workflow #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,3 +73,15 @@ jobs: | |
| nexus_password: ${{ secrets.SONATYPE_PASSWORD }} | ||
| maven_profiles: sign-source-javadoc | ||
| directory: java | ||
|
|
||
| publish-go: | ||
| name: Create go/* tag | ||
| needs: create-release | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Create go/* tag | ||
| run: |- | ||
| git config user.name "cukebot" | ||
| git config user.email "[email protected]" | ||
| git tag "go/${{ steps.create-release.outputs.version }}" | ||
|
There was a problem hiding this comment. We could also use the https://github.com/cucumber-actions/versions action as a prior step in this workflow. Or, if we factor out our own action for this we can make it self-sufficient about looking up the version. |
||
| git push --tags | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it's trivial, I suggest we factor this out into an action too. That way we keep symmetry with the other publish jobs, and we also have a single lever we can move if we need to make cross-project modifications about how Go packages are released (such as publishing binaries etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, but I'd prefer to extract it after we're sure it works. It's easier to iterate that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmyeah. Remember how hard these are to test though - really the only way to test it is to run it and make a release. If we have it in a separate action we can unit test that at least, which gives us a bit more confidence when we bolt the whole thing together.
I've run out of time today but I can do this tomorrow.