Fix get_elements_dataframe with attribute same name #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where get_elements_dataframe fails when an attribute has the same name as a dimension. The fix moves column renaming logic to occur before DataFrame operations and handles the dimension/hierarchy name separately from attribute renaming.
- Moved attribute column renaming logic to execute before DataFrame pivot operations
- Separated dimension name handling from attribute renaming to prevent conflicts
- Added comprehensive test coverage for the edge case scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Tests/ElementService_test.py | Adds test setup and test cases for dimension with same-named attribute |
| TM1py/Services/ElementService.py | Refactors column renaming logic to handle attribute names matching dimension names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Good catch! Thanks for the contribution Gary! |
MariusWirtz
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1234 get_elements_dataframe with attribute same name as dimension