Skip to content

fix(sdk): support LoadBalancer exposeType in ExposedMonopod #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

fix(sdk): support LoadBalancer exposeType in ExposedMonopod #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions sdk/kubernetes/exposed-monopod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ func NewExposedMonopod(ctx *pulumi.Context, name string, args *ExposedMonopodArg
return emp, nil
}

func (emp *ExposedMonopod) defaults(args *ExposedMonopodArgsRaw) *ExposedMonopodArgsRaw {
if args == nil {
args = &ExposedMonopodArgsRaw{}
}
return args
}

func (emp *ExposedMonopod) check(args ExposedMonopodArgsOutput) error {
// In-depth checks
wg := sync.WaitGroup{}
Expand All @@ -91,7 +84,7 @@ func (emp *ExposedMonopod) check(args ExposedMonopodArgsOutput) error {

// Then run the subset if no error yet
for _, p := range c.Ports {
if !slices.Contains([]ExposeType{ExposeNodePort, ExposeIngress}, p.ExposeType) {
if !slices.Contains([]ExposeType{ExposeNodePort, ExposeIngress, ExposeLoadBalancer}, p.ExposeType) {
err = multierr.Append(err, fmt.Errorf("unsupported expose type %s", p.ExposeType))
}
}
Expand Down
Loading