-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: Upload service #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds file upload functionality to the Functions Access Service, expanding its capabilities beyond number generation to include methods for uploading files to the CIM Database Cloud.
Key changes:
- Refactored service architecture to use metadata-based initialization instead of direct URL/token parameters
- Added comprehensive file upload service with presigned URL support and chunked uploads
- Updated existing tests and added extensive test coverage for the new upload functionality
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tests/test_service.py |
Refactored existing tests to use MetaData objects and added comprehensive test suite for FileUploadService |
pyproject.toml |
Updated version and added type stubs for requests and PyYAML |
mkdocs.yml |
Added service documentation reference |
docs/reference/service.md |
Added comprehensive documentation for service API including file upload methods |
csfunctions/service/numgen.py |
Simplified by removing duplicate classes and importing from base module |
csfunctions/service/file_upload_schemas.py |
Added Pydantic models for file upload request/response schemas |
csfunctions/service/file_upload.py |
Implemented FileUploadService with chunked upload, error handling, and abort functionality |
csfunctions/service/base.py |
Created base service class with metadata-based initialization and enhanced error handling |
csfunctions/service/__init__.py |
Added service module initialization with proper exports |
csfunctions/handler.py |
Updated to use metadata-based service initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Julian Alberts <[email protected]>
Co-authored-by: Julian Alberts <[email protected]>
Add methods for uploading files to CIM Database Cloud via the Functions Access Service.