Skip to content

Conversation

@asterikx
Copy link

Hi @cschroeter, I just stumbled across a few remaining accent color tokens, which I fixed in this PR. Thank you!

@vercel
Copy link

vercel bot commented Nov 19, 2024

@asterikx is attempting to deploy a commit to the Personal Team on Vercel.

A member of the Team first needs to authorize it.

@tien
Copy link

tien commented Dec 8, 2024

@cschroeter There are multiple bugs caused by this, would be great to have the PR prioritised 🙏

@tien
Copy link

tien commented Mar 24, 2025

@cschroeter I know that you are busy, but would be great if you can at least have this PR merged, thank you.

@mgoodfellow
Copy link

Sorry, I've just seen this, I'm surprised the issue was around last year and still persisting, I didn't think to look back so far, and I just opened a new PR regarding it.

I notice that since this PR was opened, the reference in global-css.ts has been fixed on master, but not unfortunately the button references.

Anyway, there is also a new PR which just focuses on the outstanding issues to save this being corrected for merge, or alternatively, if this PR is updated that would be great as well.

It is a bit of a blocker for us to adopt ParkUI, and in fact the bugs are present on ParkUI website and in addition the ArkUI website itself - more info here: #513

@mgoodfellow
Copy link

So in case anyone else needs it, you can fix the last 2 remaining bugs with the following theme extends

recipes: {
                button: {
                    variants: {
                        variant: {
                            outline: {
                                _selected: {
                                    background: 'colorPalette.default',
                                    borderColor: 'colorPalette.default',
                                    color: 'colorPalette.fg',
                                    _hover: {
                                        background: 'colorPalette.emphasized',
                                        borderColor: 'colorPalette.emphasized',
                                    },
                                },
                            },
                        },
                    },
                },
            },
            slotRecipes: {
                treeView: {
                    base: {
                        branchIndicator: {
                            color: 'colorPalette.default',
                        },
                        item: {
                            _selected: {
                                background: 'colorPalette.2',
                                color: 'colorPalette.text',
                                _hover: {
                                    background: 'colorPalette.2',
                                    color: 'colorPalette.text',
                                },
                                _before: {
                                    bg: 'colorPalette.default',
                                },
                            },
                        },
                    },
                },
            },

@cschroeter
Copy link
Owner

Fixed in Park UI 1.0

@cschroeter cschroeter closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants