-
Notifications
You must be signed in to change notification settings - Fork 296
4.0.0 #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rongxin-liu
wants to merge
94
commits into
develop
Choose a base branch
from
4.0.0-dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
4.0.0 #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch invis chars in CLI
Added feature where invisible chars are highlighted in the Expected vs Actual output terminals
add motivational msgs
Assert statements will now raise a check50.Failure by default
…t; in which builtins were overwritten by context; added tokenization of vars
--assertion-rewrite as an optional flag to override ENABLE_CHECK50_ASSERT
Add authentication method flags
…ly; add unit tests for JSON serialization
Serialize expected and actual values correctly
internationalization
Added _process_list as a _raw and _truncate helper
Improve diff visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements and new features to the
check50
codebase, focusing on better assertion handling and error reporting.Assertion Handling Improvements:
check50/assertions/rewrite.py
module, which rewritesassert
statements intocheck50_assert
calls. This allows for custom exception handling and better integration withcheck50
's error reporting.check50/assertions/runtime.py
module, defining thecheck50_assert
function. This function evaluates conditions, raises appropriate exceptions (Mismatch
,Missing
, orFailure
), and provides detailed context for failed assertions.rewrite
andrewrite_enabled
functions into the main execution flow incheck50/__main__.py
. If the rewrite feature is enabled,assert
statements in check files are replaced withcheck50_assert
calls.Error Reporting Improvements:
Mismatch
exception incheck50/_api.py
to provide more detailed and user-friendly error messages, including truncation logic for long outputs._truncate
helper function incheck50/_api.py
to dynamically truncate strings based on differences with other strings or fixed limits. This improves readability of error messages.