Add TypeAliasTopLevel support to read_storage
#2746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #2522.
I use pre-existing fields of
TypeAliasTopLevel
to handle usingread_storage
on aliasedElementaryType
instances, e.g.,AFAICT, this doesn't cover user defined types, but it seems like the above reproducer can be addressed by attributes of the
TypeAliasTopLevel
class.This is the output I observe when I run
get_storage_layout()
:I couldn't get the test I added to run on my local machine, so I'll wait for the CI to run/if anyone has suggestions for changing things.