Skip to content

Fix cases of echidna printer crashing #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parent: Fix arguments passed to `func` callable in `get_all_storage_variables`
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix cases of echidna printer crashing #2727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beb6dd9
Fix crash when casting an address and accessing its members
smonicas May 26, 2025
666e61b
Fix crash when casting a string to byte*
smonicas May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions slither/visitors/expression/constants_folding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,14 @@ def _post_member_access(self, expression: expressions.MemberAccess) -> None:
):
# User defined type .wrap call handled in _post_call_expression
return
elif (
isinstance(expression.expression, TypeConversion)
and expression.expression.type == ElementaryType("address")
and expression.member_name in ["balance", "code", "codehash"]
):
# We need to raise NotConstant for these case here otherwise expression.expression.value would crash in the following condition
# because TypeConversion does not have a value. See https://github.com/crytic/slither/issues/2717
raise NotConstant
elif (
isinstance(expression.expression.value, Contract)
and expression.member_name in expression.expression.value.variables_as_dict
Expand Down Expand Up @@ -442,6 +450,8 @@ def _post_type_conversion(self, expression: expressions.TypeConversion) -> None:
value = int.from_bytes(expr.value, "big")
elif str(expression.type).startswith("byte") and isinstance(expr.value, int):
value = int.to_bytes(expr.value, 32, "big")
elif str(expression.type).startswith("byte") and isinstance(expr.value, str):
value = expr.value
else:
value = convert_string_to_fraction(expr.converted_value)
set_val(expression, value)