Skip to content

Conversation

jishudashen
Copy link

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2025

CLA assistant check
All committers have signed the CLA.

@jishudashen
Copy link
Author

jishudashen commented Aug 22, 2025

@anishnaik Thanks for your review! If anything need I to do, Please feel free to tell me.

@jishudashen
Copy link
Author

The CI error seems unrelated to this change

⇾ [FAILED] Assertion Test: TestExternalLibrary.fuzz_me()
Test for method "TestExternalLibrary.fuzz_me()" resulted in an assertion failure after the following call sequence:
[Call Sequence]
1) TestExternalLibrary.fuzz_me()() (block=23888, time=131275, gas=12500000, gasprice=1, value=0, sender=0x20000)
[Execution Trace]
 => [call] TestExternalLibrary.fuzz_me()() (addr=0x4B38070A432773e11B9E2A9967285Dd7b1f862B3, value=0, sender=0x20000)
	 => [proxy call] TestExternalLibrary -> Library3.getLibrary()() (addr=0x4B38070A432773e11B9E2A9967285Dd7b1f862B3, code=0xdbb516dbcC8c91A999eB6706cd0a03eAAfF6Cdc0, value=0, sender=0x20000)
		 => [proxy call] TestExternalLibrary -> Library2.getLibrary()() (addr=0x4B38070A432773e11B9E2A9967285Dd7b1f862B3, code=0x9bAfD307270677A3C3654B40F3F43a043B81f284, value=0, sender=0x20000)
			 => [proxy call] TestExternalLibrary -> Library1.getLibrary()() (addr=0x4B38070A432773e11B9E2A9967285Dd7b1f862B3, code=0xA647ff3c36cFab592509E13860ab8c4F28781a66, value=0, sender=0x20000)
				 => [return ("Library")]
			 => [return ("Library")]
		 => [proxy call] TestExternalLibrary -> Library1.getLibrary()() (addr=0x4B38070A432773e11B9E2A9967285Dd7b1f862B3, code=0xA647ff3c36cFab592509E13860ab8c4F28781a66, value=0, sender=0x20000)
			 => [return ("Library")]
		 => [return ("Library")]
	 => [panic: assertion failed]

@jishudashen
Copy link
Author

Hi, @anishnaik Could you please review this PR when you have time? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants