-
Notifications
You must be signed in to change notification settings - Fork 2
[L4R5ZI] Local benchmarks for SHA3/SHAKE input & output sizes as required by ML-KEM #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jschneider-bensch
wants to merge
7
commits into
main
Choose a base branch
from
jonas/sha3-mlkem-benches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is taken from mainline libcrux at commit 2adf9e447257ca4d57c1f40aa4f6f761070a27c0 by @karthikbhargavan.
Contributor
Author
|
The version of SHA-3 in this branch as of |
Contributor
Author
|
I have a PR for the pqm4 bindings of the FIPS202 API here. It also runs the same benchmarks as I have here using the pqm4 bindings. Running these we get: (Some lines are lost, looks like) |
PQM4 SHA3/SHAKE benchmarks for ML-KEM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prerequisite for optimizing in SHA-3 it will be good to focus on the exact input/output sizes that matter in ML-KEM.
This PR can serve as a basis for that, and also includes a small utility for switching on the hardware RNG on the L4R5ZI.
Note that the functions under test are
#[inline(never)]here at the moment, so as to get sensible cycle measurements. It shouldn't get merged as is for that reason.Fixes #53