Skip to content

WIP Optimize docker build caching #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP Optimize docker build caching #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a2cf82
Try to make the gha cache work
baschny Mar 24, 2025
a09086a
Also ignore .git in the docker context
baschny Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/.git
/.buildx-cache
/.github
/example-app
8 changes: 4 additions & 4 deletions .github/workflows/build-and-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ jobs:
tags: "croneu/phpapp-fpm:php-${{ matrix.php-version }}"
platforms: ${{ env.PLATFORMS }}
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
cache-from: type=gha,scope=php-${{ matrix.php-version }}-${{ env.PLATFORMS }}
cache-to: type=gha,mode=max,scope=php-${{ matrix.php-version }}-${{ env.PLATFORMS }}
target: php-fpm
build-args: |
PHP_MINOR_VERSION=${{ matrix.php-version }}
Expand Down Expand Up @@ -111,8 +111,8 @@ jobs:
tags: "croneu/phpapp-ssh:php-${{ matrix.php-version }}-node-${{ matrix.node-version }}"
platforms: ${{ env.PLATFORMS }}
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
cache-from: type=gha,scope=php-${{ matrix.php-version }}-node-${{ matrix.node-version }}-${{ env.PLATFORMS }}
cache-to: type=gha,mode=max,scope=php-${{ matrix.php-version }}-node-${{ matrix.node-version }}-${{ env.PLATFORMS }}
target: ssh
build-args: |
PHP_MINOR_VERSION=${{ matrix.php-version }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:
tags: "croneu/phpapp-fpm:php-${{ matrix.php-version }}"
platforms: ${{ env.PLATFORMS }}
push: false
cache-from: type=gha
cache-to: type=gha,mode=max
cache-from: type=gha,scope=php-${{ matrix.php-version }}-${{ env.PLATFORMS }}
cache-to: type=gha,mode=max,scope=php-${{ matrix.php-version }}-${{ env.PLATFORMS }}
target: php-fpm
build-args: |
PHP_MINOR_VERSION=${{ matrix.php-version }}
Expand Down Expand Up @@ -76,8 +76,8 @@ jobs:
tags: "croneu/phpapp-ssh:php-${{ matrix.php-version }}-node-${{ matrix.node-version }}"
platforms: ${{ env.PLATFORMS }}
push: false
cache-from: type=gha
cache-to: type=gha,mode=max
cache-from: type=gha,scope=php-${{ matrix.php-version }}-node-${{ matrix.node-version }}-${{ env.PLATFORMS }}
cache-to: type=gha,mode=max,scope=php-${{ matrix.php-version }}-node-${{ matrix.node-version }}-${{ env.PLATFORMS }}
target: ssh
build-args: |
PHP_MINOR_VERSION=${{ matrix.php-version }}
Expand Down