adding solid credentials #31
Conversation
There was a problem hiding this comment.
These is a newer OpenBadges v3.0.2 context available, but it introduces a bug or two...so we should likely hold off upgrading to that until a future point release.
Otherwise, this looks good to go!
Thanks, @gordoncavanaugh and sorry for the wait!
| @@ -0,0 +1,41 @@ | |||
| { | |||
| "@context": [ "https://www.w3.org/2018/credentials/v1", "https://purl.imsglobal.org/spec/ob/v3p0/context.json", "https://w3id.org/security/suites/ed25519-2020/v1" ], | |||
There was a problem hiding this comment.
Remove https://w3id.org/security/suites/ed25519-2020/v1.
| "description": "Achievement of the General Maintenance badge requires demonstrated fundamental knowledge and understanding of concepts related to general maintenance practices and basic repair activities. Badge earners have the ability to conduct preventive and corrective maintenance, basic repair, and housekeeping on equipment or equipment systems, and have the following micro-badges: Maintenance and Repair; Safety and Housekeeping." | ||
| } | ||
| }, | ||
| "proof": { |
| "description": "Solutions for Information Design, LLC.\r\nEndorsed by The Manufacturing Institute", | ||
| "url": "https://solidinfodesign.com", | ||
| "image": { | ||
| "id": "https://certificates.cs50.io/static/success.jpg", |
There was a problem hiding this comment.
Issuer image should be changed to a picture that represents the issuer, not the achievement.
| "type": "AchievementSubject", | ||
| "name": "Gordon Cavanaugh", | ||
| "achievement": { | ||
| "id": "http://digitalcredentials.mit.edu", |
There was a problem hiding this comment.
id should be unique to the achievement.
i.e. http://digitalcredentials.mit.edu/achievements/018b8186-5743-7622-923c-cd477d2ab2fd
| "issuer": { | ||
| "id": "did:key:z6Mkr3oy4PPP5cBpdgvmz1mqqPWkVrzzkEq2btA1exN9YiVX", | ||
| "type": "Profile", | ||
| "name": "SOLID, LLC.\r\nEndorsed by The Manufacturing Institute", |
There was a problem hiding this comment.
Recommend removing \r\. These characters may be rendered as-is in some wallets.
|
Thanks for the review, @gannan08. My bad for reviewing it too quickly. @gordoncavanaugh are these changes you're available to make? If not, I can make them for you. Just let me know. Thanks! |
|
@gordoncavanaugh are you still interested in getting this example into the VC Playground? It's been awhile, but happy to revisit this if you are. |
No description provided.