-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for Fivetran's TIME_NAIVE data type
#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds support for Fivetran's NAIVE_TIME type with bidirectional type mappings and a new CrateDBKnowledge.replace_values() that parses TIME strings, normalizes them to a fixed date (1970-01-01), and converts to milliseconds since midnight. Adds python-dateutil dependency and updates tests/fixtures. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related issues
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… fails" This reverts commit 205ba94.
About
Mapping the
TIME_NAIVEtype didn't work before, because CrateDB can't storeTIMEtypes.Review
Note this PR is stacked upon GH-112, but can be reviewed independently.