Skip to content

Enable Rector php 8.0 set #16711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samsonasik wants to merge 9 commits into
base: 5.x
Choose a base branch
from
Open

Enable Rector php 8.0 set #16711

samsonasik wants to merge 9 commits into from

Conversation

@samsonasik
Copy link
Contributor

@samsonasik samsonasik commented Feb 16, 2025 •
edited
Loading

Description

Applied changes:

  • use str_contains/str_starts_with/str_ends_with
  • use static::class over get_class($this)
  • remove unused variable cactch on try catch
  • use $object::class over get_class($object)
  • apply constructor promotion
  • make implements \Stringable with __toString() method class.

Related issues

@samsonasik samsonasik force-pushed the rector-enable-php80 branch 2 times, most recently from d262f20 to ac0eb0a Compare February 16, 2025 09:18
@samsonasik
Copy link
Contributor Author

samsonasik commented Feb 16, 2025

Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 18, 2025
View reviewed changes
@samsonasik
Copy link
Contributor Author

samsonasik commented Feb 20, 2025

@brandonkelly Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 20, 2025
View reviewed changes
@samsonasik
Copy link
Contributor Author

samsonasik commented Feb 20, 2025

@brandonkelly Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 20, 2025
View reviewed changes
@samsonasik
Copy link
Contributor Author

samsonasik commented Feb 20, 2025

@brandonkelly Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 20, 2025
View reviewed changes
@samsonasik
Copy link
Contributor Author

samsonasik commented Feb 21, 2025

@brandonkelly Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 25, 2025
View reviewed changes
@samsonasik
Copy link
Contributor Author

samsonasik commented Mar 1, 2025

@brandonkelly Ready to merge 👍

@samsonasik samsonasik requested a review from brandonkelly March 1, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @brandonkelly