Skip to content

[func.wrap.move.class, func.wrap.copy.class] Fix singular and plural #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

[func.wrap.move.class, func.wrap.copy.class] Fix singular and plural #8232

merged 1 commit into from
Sep 15, 2025

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Sep 14, 2025

Constructor and assignment should be plural because there are multiple ones.
Destructor should be singular because there is only one.

@hewillk
[func.wrap.move.class, func.wrap.copy.class] Fix singular and plural
d33549c 
Constructor and assignment should be plural because there are multiple ones. Destructor should be singular because there is only one.
jensmaurer
jensmaurer approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably something about global consistency to be said here, but this is a step towards at least a local optimum.

@jensmaurer jensmaurer merged commit 8d0144f into cplusplus:main Sep 15, 2025
2 checks passed
@hewillk hewillk deleted the main-c branch September 15, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hewillk @jensmaurer