Skip to content

Conversation

@shoom3301
Copy link
Collaborator

Summary

Fixes https://www.notion.so/cownation/Add-partial-approval-to-the-ETH-flow-in-Safe-28a8da5f04ca80298779d1530db170e0?v=2578da5f04ca81c385e6000cca94fa88&source=copy_link

image

To Test

  1. When selling ETH in Safe, it should do a bundle with Wrap, Approve, and Swap.
  2. Approve should be wired up with partial approval logic.

@shoom3301 shoom3301 requested a review from a team October 22, 2025 08:16
@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cowfi Ready Ready Preview Oct 24, 2025 2:42pm
explorer-dev Ready Ready Preview Oct 24, 2025 2:42pm
swap-dev Ready Ready Preview Oct 24, 2025 2:42pm
widget-configurator Ready Ready Preview Oct 24, 2025 2:42pm
2 Skipped Deployments
Project Deployment Preview Updated (UTC)
cosmos Ignored Ignored Oct 24, 2025 2:42pm
sdk-tools Ignored Ignored Preview Oct 24, 2025 2:42pm

@shoom3301 shoom3301 requested a review from a team October 22, 2025 08:16
@shoom3301 shoom3301 self-assigned this Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/safe-partial-approvals-eth-flow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants