Skip to content

Conversation

@fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Oct 15, 2025

Summary

Ensure CoW Swap falls back to Inter when Studio Feixen lacks glyphs, so Cyrillic and other scripts render consistently across the UI.

Screenshot 2025-10-15 at 15 09 57

To Test

  1. Launch the cowswap-frontend locally and switch the UI language to Russian (or another Cyrillic locale).
  • Verify general UI text now uses Inter (matching Latin glyph metrics) instead of Arial.
  • Check key components (headers, tooltips, buttons) render Cyrillic characters without layout shifts or clipping.
  • Confirm Latin locales still render with Studio Feixen where available.

Background

Studio Feixen does not ship Cyrillic glyphs, causing browsers to drop to Arial. Adding Inter as the next fallback keeps typography consistent across locales.

Summary by CodeRabbit

  • Style
    • Updated the primary font stack to include Inter and Inter Variable before Arial, retaining existing fallbacks.
    • Text across the interface will render with Inter where available; appearance may be subtly refined.
    • Applies to all components using the primary font token; no behavioral changes.
    • No user settings or configurations are affected; this is a visual update only.

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cowfi Ready Ready Preview Oct 20, 2025 1:23pm
explorer-dev Ready Ready Preview Oct 20, 2025 1:23pm
swap-dev Ready Ready Preview Oct 20, 2025 1:23pm
widget-configurator Ready Ready Preview Oct 20, 2025 1:23pm
2 Skipped Deployments
Project Deployment Preview Updated (UTC)
cosmos Ignored Ignored Oct 20, 2025 1:23pm
sdk-tools Ignored Ignored Preview Oct 20, 2025 1:23pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@fairlighteth fairlighteth self-assigned this Oct 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Walkthrough

Updated font-family stacks to include 'Inter var' and 'Inter' before Arial in UI constants and theme variables. No logic or API shape changes beyond the Font.family string update.

Changes

Cohort / File(s) Summary
Font stack updates
libs/ui/src/consts.ts, libs/ui/src/theme/ThemeColorVars.tsx
Added 'Inter var' and 'Inter' to primary font-family stacks; in consts.ts, updated exported Font.family from 'studiofeixen', Arial, sans-serif to 'studiofeixen', 'Inter var', 'Inter', Arial, sans-serif; in ThemeColorVars, extended UI.FONT_FAMILY_PRIMARY similarly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • alfetopito
  • elena-zh

Poem

I hop through styles with gentle care,
Dropping Inter threads into the air.
Stacks aligned, kerning tight,
Letters dance in softer light.
Thump-thump—fonts now feel just right! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title succinctly describes the main change—adding Inter to the font family in UI constants and theme—using clear and concise language and following the conventional commit style. It precisely highlights the primary update without including extraneous details. A teammate scanning the history can quickly understand the key modification being applied.
Description Check ✅ Passed The pull request description adheres closely to the repository template by including a summary with context and a screenshot, a detailed To Test section with checkboxes for validating functionality, and a background section explaining the rationale. All required elements are present and clearly articulated, making it easy for reviewers and QA to understand the purpose and verify the change. Since there is no specific issue number to reference, omitting a Fixes tag is acceptable given the template's conditional nature.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/fallback-font

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fairlighteth fairlighteth requested review from a team October 15, 2025 14:11
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d33817 and d626535.

📒 Files selected for processing (2)
  • libs/ui/src/consts.ts (1 hunks)
  • libs/ui/src/theme/ThemeColorVars.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Cypress
  • GitHub Check: Setup
🔇 Additional comments (1)
libs/ui/src/consts.ts (1)

46-46: LGTM! Font.family constant correctly updated.

The font-family stack update is consistent with the corresponding change in ThemeColorVars.tsx and properly maintains the exported constant structure.

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alfetopito alfetopito merged commit 024ffb2 into develop Oct 20, 2025
15 checks passed
@alfetopito alfetopito deleted the fix/fallback-font branch October 20, 2025 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants