-
Notifications
You must be signed in to change notification settings - Fork 145
fix: update font family to include 'Inter' in UI constants and theme #6370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
WalkthroughUpdated font-family stacks to include 'Inter var' and 'Inter' before Arial in UI constants and theme variables. No logic or API shape changes beyond the Font.family string update. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
libs/ui/src/consts.ts(1 hunks)libs/ui/src/theme/ThemeColorVars.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Cypress
- GitHub Check: Setup
🔇 Additional comments (1)
libs/ui/src/consts.ts (1)
46-46: LGTM! Font.family constant correctly updated.The font-family stack update is consistent with the corresponding change in
ThemeColorVars.tsxand properly maintains the exported constant structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Summary
Ensure CoW Swap falls back to Inter when Studio Feixen lacks glyphs, so Cyrillic and other scripts render consistently across the UI.
To Test
Background
Studio Feixen does not ship Cyrillic glyphs, causing browsers to drop to Arial. Adding Inter as the next fallback keeps typography consistent across locales.
Summary by CodeRabbit