-
Notifications
You must be signed in to change notification settings - Fork 40
feat(headless): spike supporting spotlight content for commerce COMHUB2-1228 #6646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tooni
wants to merge
51
commits into
main
Choose a base branch
from
COMHUB2-1228
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+892
−265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMHUB2-1228
We have a new feature in Commerce called Spotlight Content. These are arbitrary bits of content that the merchandiser can have returned for their Product Listings, though in future it will be needed for Search and Recommendations as well. Here it is in the Commerce Hub preview. You can see a random bit of content mixed in with the products.
It means it no longer makes much sense for the
productslist in the responses to be called that, so there is a new list ofresultsnow, which can contain both Products and Spotlight Content. To not be a breaking change, this is an opt-in feature, where users have to send anenableResultsparam on their requests. When they send the param, theresultsfield is filled in instead of theproductsfield, and they can see their Spotlight Content. There is a doc here explaining the approach in more detail.To facilitate
enableResultsin Headless, I've tried to introduce a new option to the ProductListing controller, where the user can pass an optionalenableResultsboolean, which gets propagated down. Have I done this right? It is my first time working with Headless or Redux. The plan is that there should be no change for existing users, and users who want Spotlight Content can opt-in by sending that boolean. Do I need to update anything apart from Headless, like Atomic and stuff? Edit: After talking with Benoit Thibault and a couple others, we need only Headless support for now.