Skip to content

fix(atomic): inject tailwind properties in withTailwindStyles decorator instead of default theme #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fpbrault
Copy link
Contributor

This PR removes the TailwindCSS @Property rules from the default theme (coveo.css) and changes the withTailwindStyles decorator so that it injects them (only once) in the document root instead. This prevents issues that can happen when modifying/not using the default theme.

This is required due to @property rules not being supported in shadow roots.

Additionally it ensures that TailwindCSS @Property rules will be added/removed automatically when updating the TailwindCSS package, as they are now retrieved dynamically from the tailwindcss stylesheet.

https://coveord.atlassian.net/browse/KIT-4634

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jul 25, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 253.3 253.3 0
commerce 365.9 365.9 0
search 425.6 425.6 0
insight 416.6 416.6 0
recommendation 264.2 264.2 0
ssr 419 419 0
ssr-commerce 383 383 0

@fpbrault fpbrault requested a review from fbeaudoincoveo July 29, 2025 13:19
@fpbrault fpbrault marked this pull request as draft July 29, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants