-
Notifications
You must be signed in to change notification settings - Fork 37
Replace boost and fmt functionality with C++20 features and update CEF #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # CMakeLists.txt # plugins/csp-lod-bodies/src/TreeManager.cpp
…olled on a browser level anymore.
Co-authored-by: Simon Schneegans <[email protected]>
Schneegans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise it looks good. I'll do some in-depth testing next.
Co-authored-by: Simon Schneegans <[email protected]>
Thanks, this is not an urgent PR (also why this is in draft mode), since we currently have to support Ubuntu 22.04 which doesn't have gcc-13. Maybe in the next months we can drop Ubuntu 22.04 support. But you can review it nonetheless if you have the time. |
Schneegans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks good! Thanks for this work!
This PR replaces:
This PR also updates CEF to version 135, to fix some C++ deprecation issues.
This reduces our dependencies and makes the setup of CosmoScout VR easier.
This change requires gcc-13 or Visual Studio 2019. gcc-13 is the default compiler on Ubuntu 24.04. There are some more possible improvements in date time parsing that would require gcc-14, but since this is not the default compiler on any LTS version of Ubuntu I skipped these improvements.