feat(utils): include an address codec implementation #665
+301
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
changed the title
srdtrk
changed the title
srdtrk
commented
Sep 25, 2025
srdtrk
force-pushed
the
serdar/322-default-addrcdc
branch
from
deef085 to
41a10c9
Compare
aljo242
reviewed
Sep 25, 2025
aljo242
reviewed
Sep 25, 2025
| ) | ||
|
|
||
| // EvmCodec defines an address codec for EVM compatible cosmos modules | ||
| type EvmCodec struct { |
There was a problem hiding this comment.
This lgtm but I think this should live elsewhere (not in a utils package and also be piped into our evmd application
There was a problem hiding this comment.
@vladjdk for thoughts on locations etc
There was a problem hiding this comment.
If we are going to pipe this into our evmd. Then we might have a better case for #665 (comment) since if we used bech32, this codec would be a better drop-in replacement for the default cosmos sdk one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #633
closes: EVM-322
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch