Feat: privacy-conscious appointment stats #1210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeangelLF
reviewed
Mar 26, 2025
There was a problem hiding this comment.
Oh... I think we tried to partially solve the same thing 🙈.
Last week, I added #1206 trying to avoid the zoom meeting report because of the issues you described
- Not being able to identify users accurately
- Not having any infos on non-zoom meetings
JeangelLF
reviewed
Mar 26, 2025
| export async function populateAppointmentStats() { | ||
| logger.info('Populating appointment stats'); | ||
| const zoomMeetingReports = await prisma.lecture.findMany({ | ||
| where: { |
There was a problem hiding this comment.
Shouldn't we also exclude here those that already have the stats populated? 👀
|
@JeangelLF I see, thanks for the notice. So all that remains for closing https://github.com/corona-school/project-user/issues/1422 is the meeting duration, afaict. This I can derive from the meeting reports without any hacks. I'm gonna remove the appointment_stats data structure then and just add the |
…ve appointmentStatsId from evaluate.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only save select Zoom data to our database.
This required some very hacky workaround because I wasn't sure how to identify pupils/students in the meeting report other than separating them by having an ID and not having an ID. Is there a better way to do it?
Closes https://github.com/corona-school/project-user/issues/1422