Fix: Correct scriptOptions handling in generated daemon XML #387
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coreybutler Please merge this 🥺 . |
|
@countnazgul @coolaj86 @cwalther @coreybutler Please look into this 🥺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lib/daemon.js, when generating XML for scriptOptions,
it was generating as,
<argument>--scriptoptions=command_line_argument another_argument</argument>But it is expected as,
<argument>--scriptoptions</argument> <argument>command_line_argument another_argument</argument>So, corrected the code to generate as expected by the wrapper.
This implementation doesn't support the quoted commandline arguments with space like
node index.js "Hello world"But, this should provide enough support to start using process arguments.
Please consider 😭 this PR.
Script for installing service.
Generate XML
