Skip to content

Adopt Helm chart to mimic Amazon EKS CoreDNS naming conventions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adopt Helm chart to mimic Amazon EKS CoreDNS naming conventions #98

wants to merge 6 commits into from

Conversation

youwalther65
Copy link

  • modified Helm chart to mimic Amazon EKS CoreDNS deployment
  • minor changes due to PDB
  • modified values.yaml resources to not contain hyphen in name because this is not supported for Helm
  • added pdb.name because it does not fit intp podDisruptionBudget resource
  • removed critical-pod annotation because it is already invalid
  • final commit before submitting PR

@youwalther65
Copy link
Author

See also my feature request here

@dims
Copy link

dims commented Feb 22, 2023

cc @mrueg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youwalther65 @dims