Add chart options for pod dnsConfig and dnsPolicy #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bauer <[email protected]>
hagaibarel
requested changes
Mar 28, 2023
| {{- end }} | ||
| {{- if .Values.dnsConfig }} | ||
| dnsConfig: | ||
| {{ toYaml .Values.dnsConfig | nindent 8 }} |
There was a problem hiding this comment.
Suggested change
| {{ toYaml .Values.dnsConfig | nindent 8 }} | |
| {{- toYaml .Values.dnsConfig | nindent 8 }} |
Comment on lines
+202
to
+206
| # Configure pod DNS policy and config. | ||
| # dnsPolicy: None | ||
| # dnsConfig: | ||
| # nameservers: | ||
| # - 8.8.8.8 |
There was a problem hiding this comment.
Please add comment per attribute, e,g,:
Suggested change
| # Configure pod DNS policy and config. | |
| # dnsPolicy: None | |
| # dnsConfig: | |
| # nameservers: | |
| # - 8.8.8.8 | |
| # Configure pod DNS policy | |
| # dnsPolicy: None | |
| # Configure dnsConfig settings | |
| # dnsConfig: | |
| # nameservers: | |
| # - 8.8.8.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds
dnsConfiganddnsPolicyoptions to the chart, which allow the installer to override those options for the pod.