fix: add touch cache folder in restore to refresh the cache folder atime #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add touch cache folder in restore to refresh the atime
…dist (#2) * fix: touch cache folder to refresh atime * fix: use seprated touch cmd * fix: touch cachePath instead * update: src files after test done
tomchang-tubi
changed the title
|
monitoring for 2 week, and the fix looks solid, reopen this pr for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When restoring cache, the target file’s access time (atime) was not being updated in some cases.
This could cause certain cleanup or cache retention strategies that rely on atime to behave incorrectly.
Has report this to #33
Change details:
Why this matters:
By updating the target file’s atime on restore, we ensure that cache retention policies relying on file access time work as expected and avoid unintentional cache purging.
How I test the touch works:
Test on macOS, has monitor for 3 week, the folder atime are updated everytime load the cache. And now the automatically clean up are working fine and only cleaned the cache > 7 days not restored.