-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: relocate the codebase indexing tab #6939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CI error appears to be spurious: |
This moves the codebase indexing status from its current location underneath the Settings icon, to a new tab next to the Docs tab, inline with the others. This improves the accessibility of the codebase index tab, making it easier to find and requiring only one click to reach. This also brings it in line with the docs indexing tab so that they are providing a more similar experience. Additionally, this fixes the text on the disabled state to show "Enable Indexing", matching the text on the toggle in the Settings tab.
81d3c3d
to
4c4240f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shssoichiro the current direction is to slowly deprecate codebase RAG indexing, which is why this is more hidden than docs. The notch tabs are precious UX space and we've decided to not add codebase to this for now. Also, codebase indexing is designed to be in the background so the user doesn't have to think about it. If they do, there's probably an issue with the system. In which situations do you frequently find yourself visiting the indexing tab?
The copy fix (disable -> enable) would be a great fix, would love to merge that.
The issues I've found that led to wanting this tab more visible are indeed related to codebase indexing errors. The most frequent being that the codebase indexing will fail when VSCode initially loads (the common error seems to be May I ask why the codebase indexing overall is being deprecated? I know that is outside the scope of this ticket, but I'm curious as it seems like a useful feature. |
@RomneyDa Can you tell us a bit more why are you moving into the direction of RAG deprecation? It seems like a very useful feature, at least for me. Is the plan is to make it more implicit (use under the hood usage as a tool) or you think that grep/search tools are more useful than codebase index? |
@Pyroboomka @shssoichiro exactly, grep and glob in practice seem much more effective. We don't have strong evals on this but feedback has been pretty strong towards agent grep/glob vs codebase. Would definitely be interested in any case studies/evals that show otherwise! |
@shssoichiro is there an issue for the signal undefined error? Maybe we could fix the error to prevent needing to reindex frequently |
@shssoichiro talked with team, sounds like we won't move forward with this move but would be interested to fix the bug you mentioned. I also opened another PR with the |
Description
This moves the codebase indexing status from its current location underneath the Settings icon, to a new tab next to the Docs tab, inline with the others.
This improves the accessibility of the codebase index tab, making it easier to find and requiring only one click to reach. This also brings it in line with the docs indexing tab so that they are providing a more similar experience.
Additionally, this fixes the text on the disabled state to show "Enable Indexing", matching the text on the toggle in the Settings tab.
Checklist
Screen recording or screenshot
Settings view looks correct with Indexing tab removed:
Codebase tab displays, and has a tooltip when hovered:
When opened, the Codebase tab displays the same contents as the current Indexing tab:
The disabled state also displays correctly and the text matches the settings toggle:
Tests
All existing tests pass, and manual verification was done (see screenshots).
Summary by cubic
Moved the codebase indexing status to a new tab next to the Docs tab for easier access and updated the disabled state text to say "Enable Indexing".