Skip to content

Update GetTransactions method with workchain, shard and seqno parameters #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update GetTransactions method with workchain, shard and seqno parameters #131

wants to merge 1 commit into from

Conversation

DenisAkm
Copy link

@DenisAkm DenisAkm commented Nov 8, 2024

No description provided.

@naxoootcnjncgjnnxfhjjv
Copy link

``gh pr checkout 131

@DenisAkm
Copy link
Author

@naxoootcnjncgjnnxfhjjv ?

@naxoootcnjncgjnnxfhjjv
Copy link

#131

@CaCTuCaTu4ECKuu
Copy link

Wouldn't it be better to have 2 methods instead of just making address parameter optional?
It should be more convenient, like basic request and advanced where address indeed optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@naxoootcnjncgjnnxfhjjv naxoootcnjncgjnnxfhjjv naxoootcnjncgjnnxfhjjv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenisAkm @naxoootcnjncgjnnxfhjjv @CaCTuCaTu4ECKuu