fix: fix the timestamp cert chain validation to be independent of the order #1600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamp certificates, which are part of the SignedData, are structured differently from CBOR when forming a chain. Specifically, they are composed as a SET OF type, and the order is not considered. (Refer to RFC5652)
The existing implementation assumes that the certificate chain is structured from leaf to root, which causes some TSA to fail in processing it correctly. (example: Microsoft Timestamp Server, Java Bouncy Castle)
To address this issue, the certificate chain will be sorted into an interpretable format.
Related Issue : #1590
Changes in this pull request
Before validating the timestamp certificate chain, rearrange it from leaf to root.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.