-
Notifications
You must be signed in to change notification settings - Fork 111
feat: check if stream matches input format via file signature/structure #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mauricefisher64
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some sugguestions
3a94319 to
04cb96e
Compare
CodSpeed Performance ReportMerging #1528 will not alter performanceComparing Summary
Footnotes
|
tmathern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are unsure about mp3 and svg and need more work/verifications, I'd rather we split it out. To avoid taking the risk of breaking (currently working) edge cases.
The corollary is to add good test coverage using real files to raise confidence we covered all cases (is it even possible with mp3?).
tmathern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming the SVG related question has the same answer as MP3 (please confirm).
|
I will be changing this PR to perform the support checks as it's being read. This will be much more reliable since we can use our normal parsing methods (like XML for SVG) and it can be done in one pass. We also do this already for some formats, like GIF. |
…le-signature-check
Adds extra validation before loading the JUMBF to confirm the input format type matches the given stream, otherwise outputting a more specific error.
Some format types such as MP3 and SVG may require a more in-depth structural check.