Skip to content

Conversation

@tmathern
Copy link
Contributor

@tmathern tmathern commented Sep 23, 2025

  • Update to use latest c2pa-python SDK
  • Update manifests used for signing (spec v2)
  • Update signing code (use latest that c2pa SDK supports/has already tested in unit tests to make sure it works)

@tmathern tmathern self-assigned this Sep 23, 2025
@tmathern tmathern marked this pull request as ready for review October 6, 2025 21:01
@tmathern tmathern requested review from crandmck and gpeacock October 6, 2025 21:01
@crandmck
Copy link
Collaborator

crandmck commented Oct 17, 2025

I made some small copy edits to the README.

When I try to run the server with python app.py, I get an error.

    kms_key_id = app_config['KMS_KEY_ID']
                 ~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'KMS_KEY_ID'

I guess I need to set up the env, but I'm going to approve because I don't want to block this PR and I don't have much time atm.

@tmathern
Copy link
Contributor Author

tmathern commented Oct 23, 2025

I made some small copy edits to the README.

When I try to run the server with python app.py, I get an error.

    kms_key_id = app_config['KMS_KEY_ID']
                 ~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'KMS_KEY_ID'

I guess I need to set up the env, but I'm going to approve because I don't want to block this PR and I don't have much time atm.

Yes, the (bare-metal/developer) environment setup is relatively involved. You need a bunch of environment variables set in the environment (there are some scripts that help set up the .env file that is read on startup). It is easier to use the Docker parts for a very quick start, as those have more defaults to run OOTB.

When I set it up, I nearly always follow the whole readme from top to bottom (and you know it is relatively long by now).

I realize you may also need some version updates, as I don't know which versions of what additional tools you currently have installed...

@tmathern tmathern merged commit 1d4e4c1 into main Oct 23, 2025
1 check passed
@tmathern tmathern deleted the mathern/update-code branch October 23, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants