topology-aware: consider burstable CPU limit when picking a pool #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/topology-aware/pick-pool-by-burstable-limit
branch
from
1752b62 to
97af7d0
Compare
When picking a pool for a burstable QoS class container, take into account the CPU limit, too. For limited containers prefer pools with enough free capacity for the limit. For unlimited containers prefer pools with more free capacity left, which means in practice that such containers will typically end up in the root pool, unless affinity of topology hints dictate otherwise. Signed-off-by: Krisztian Litkey <[email protected]>
Update existing burstable placement test for altered behavior. Add new test to verify CPU limit based burstable placement of limited and unlimited burstable containers. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/topology-aware/pick-pool-by-burstable-limit
branch
from
97af7d0 to
21943c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves CPU resource allocation for burstable QoS class containers.
Currently CPU burstability is not taken into account when a pool is picked for a container. For containers with high burstability (large CPU limit - CPU request), this can result in an assignment which cannot have any or enough excess CPU capacity for bursting.
This PR changes that behavior. When picking a pool for a burstable QoS class container, take into account the CPU limit, too. For limited burstable containers, prefer pools with enough free capacity for the limit. For unlimited burstable containers, prefer pools with more free capacity left. This means in practice that unlimited containers will typically end up in the root pool, unless affinity, memory types, or topology hints dictate otherwise.