Update bridge.go #1160
Open
Update bridge.go #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port Isolation of an interface in the Linux bridge is only supported by a subset of interfaces. This code change checks that the interface is of type veth, vnet or tap before attempting to isolate the interface to the bridge. The existing code would try to isolate any interface type with no checking and would easily cause an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port Isolation of an interface in the Linux bridge is only supported by a subset of interfaces. This code change checks that the interface is of type veth, vnet or tap before attempting to isolate the interface to the bridge. The existing code would try to isolate any interface type with no checking and would easily cause an error. I'm thinking this logic might also need to be applied to other types of interface modes such as hairpin etc.
This issue was discovered when using the portIsolation setting in Multus which wasn't causing interfaces to become isolated.