Discovered a bug when trying to use the Vendor Object. It looks like… #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the calling sequence of
QuickBooks_QBXML_Object::asQBXML() recently changed, and a constant was moved:
QUICKBOOKS_OBJECT_XML_DROP -> QuickBooks_XML::XML_DROP. However, QuickBooks_QBXML_Object_Vendor::asQBXML
still had the old definition and referenced the old constant, which no longer existed, resulting
in an error (which would have been ignored in environments with STRICT error reporting off). Upon
further examination I realized that the asQBXML, asArray, and _cleanup methods in
QuickBooks_QBXML_Object_Vendor actually didn't do anything anyway but just deferred everything
to the parent. As a result, I fixed this by simply removing all three method from QuickBooks_QBXML_Object_Vendor.
I checked and noticed that many classes had this same problem, so I went through all of them and removed
asQBXML, asArray, and _cleanup only when I could safely do so (i.e. only when they had no functionality of their
own and were simply deferring to the parent class).
It doesn't look like you have any tests to run to make sure I didn't accidentally break anything, and
I don't have any quick ways to check all of these methods. However I went through my changes carefully,
so hopefully this commit will work without issue for you: please double check my work.
Also, I realized at push time that my editor was still configured to automatically strip extraneous whitespace from the end of lines. This is why so many lines are changed. If this is a problem I can re-apply my changes without the auto-trimming of whitespace.