-
Notifications
You must be signed in to change notification settings - Fork 175
Update schema default value and readme #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is good, but the change log could be more specific.
|
|
||
| ### Bug fixes | ||
|
|
||
| * The default value for `enable_currentUserHome` has been changed from `false` to `true` to properly reflect the documentation. This change only affects `.pkg` installers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The default value for `enable_currentUserHome` has been changed from `false` to `true` to properly reflect the documentation. This change only affects `.pkg` installers. | |
| * PKG: Restore the default value of `enable_currentUserHome` to the old default value (`true`). (#1070 via #1088) |
Imperative mood is preferred overall. I would also like to clarify that this used to be the default value, it's not just a mishap in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ideas, applied the suggestion.
|
|
||
| ### Docs | ||
|
|
||
| * The displayed text during installation of `.pkg` installers has been updated to clarify affected shells with default installer behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The displayed text during installation of `.pkg` installers has been updated to clarify affected shells with default installer behavior. | |
| * PKG: Clarify that the profile of all available shells will be modified by default. (#1070 via #1088) |
More specific that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I applied the suggestion.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?