Skip to content

Conversation

@lrandersson
Copy link
Contributor

@lrandersson lrandersson commented Oct 15, 2025

Description

  1. Based on Several confusing and misleading statements in macOS pkg installer #1070 this PR updates the default value in the schema to properly reflect what the documentation says.
  2. Moreover, a minor change to the readme based on the comments in the same PR.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Oct 15, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 15, 2025
@lrandersson lrandersson marked this pull request as ready for review October 15, 2025 15:15
@lrandersson lrandersson requested a review from a team as a code owner October 15, 2025 15:15
Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good, but the change log could be more specific.


### Bug fixes

* The default value for `enable_currentUserHome` has been changed from `false` to `true` to properly reflect the documentation. This change only affects `.pkg` installers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The default value for `enable_currentUserHome` has been changed from `false` to `true` to properly reflect the documentation. This change only affects `.pkg` installers.
* PKG: Restore the default value of `enable_currentUserHome` to the old default value (`true`). (#1070 via #1088)

Imperative mood is preferred overall. I would also like to clarify that this used to be the default value, it's not just a mishap in the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ideas, applied the suggestion.


### Docs

* The displayed text during installation of `.pkg` installers has been updated to clarify affected shells with default installer behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The displayed text during installation of `.pkg` installers has been updated to clarify affected shells with default installer behavior.
* PKG: Clarify that the profile of all available shells will be modified by default. (#1070 via #1088)

More specific that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I applied the suggestion.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review Oct 21, 2025
@marcoesters marcoesters merged commit c5925bd into conda:main Oct 21, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

3 participants