Add support for protected conda environments #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
reviewed
Sep 11, 2025
jaimergp
reviewed
Sep 11, 2025
Fix version check and test
…ers/constructor into conda-standalone-version-helper
Jrice1317
changed the title
Create helper function for version range checks
jaimergp
reviewed
Sep 17, 2025
marcoesters
reviewed
Sep 22, 2025
marcoesters
reviewed
Sep 25, 2025
marcoesters
reviewed
Oct 1, 2025
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This reverts commit 5bfd549.
jaimergp
reviewed
Oct 2, 2025
Comment on lines
320
to
321
| if request and ON_CI: | ||
| request.addfinalizer(lambda: shutil.rmtree(str(install_dir), ignore_errors=True)) |
There was a problem hiding this comment.
Should we do this for all installers? Regardless, let's add a comment that we are doing this to free space and prevent "running out of storage" errors.
There was a problem hiding this comment.
Since we uninstall by default on Windows, I'm not worried about EXE installers. PKG installers already have that finalizer. I did add a comment though.
jaimergp
previously approved these changes
Oct 2, 2025
jaimergp
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?