-
-
Notifications
You must be signed in to change notification settings - Fork 7
spatialdata 0.3.0 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2025.04.02.21.55.06
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14249722853. Examine the logs at this URL for more detail. |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14255354543. Examine the logs at this URL for more detail. |
|
alright, I made the call and reverted back to the original pindown of dask. This is finally ready to go! |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14269638001. Examine the logs at this URL for more detail. |
| build: | ||
| noarch: python | ||
| script: {{ PYTHON }} -m pip install . -vv | ||
| script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdblischak could you please comment on --no-deps and --no-build-isolation?
I see that they are added here in spatialdata-feedstock and in these downstream repositories:
but not in these downstream repositories:
Also the parameters are not used in these upstream repositories:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @giovp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, pip will install any missing dependencies. However, all dependencies should be specified in the recipe and installed by conda. Using the flag --no-deps is a best practice to ensure all the required dependencies are defined in the recipe. It should be added to any recipe that is missing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, pip creates a separate build environment, installs the build requirements, and build the package in this separate environment. Thus this completely defeats the purpose of using the conda recipe to specify the build requirements. Any recipe missing --no-build-isolation should have the flag added. It ensures the package is built by the conda packages indicated in the recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good habit when creating a new recipe or updating an existing one is to use grayskull, eg:
grayskull pypi --strict-conda-forge spatialdata
grep script spatialdata/meta.yaml
## script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolationwhich is the officially recommended method to generate conda-forge recipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will add these parameters to the incoming conda releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick follow-up to add some more nuance. While the official stance is to add --no-deps --no-build-isolation, there is some debate in the community (conda/grayskull#582, conda/grayskull#584). Essentially in most cases the flags are redundant because conda-build/rattler-build set env vars to accomplish this. However, they are required for recipes with multiple outputs and in the past when conda-build has failed to set the env vars.
Personally, I like including the flags even when they are redundant because they make it more transparent to readers of the recipe that these pip behaviors are being enforced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the extra details!
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes #12
Closes #14
Blocked by conda-forge/multiscale-spatial-image-feedstock#5
Local rerendering had no effect because recently done in #10. The
python_minin the recipe overrides thepython_minin.ci_support/.Explanation of differences from the 0.3.0
pyproject.toml:<2025for dask-core is because the breaking change was introduced in 2025.1.0. There is no reason that I am aware of that spatialdata 0.3.0 shouldn't be compatible with the 2024.12 minor releases of dask