Skip to content

Conversation

yarikoptic
Copy link
Member

TODO: verify that test failed before & fix the test so then it would pass here.. most likely needs a new python -m venv temppath and run with temppath/bin/python -- should not crash and should complain with the warning like we do.

…(only)

TODO: verify that test failed before & fix the test so then it would pass here
Copy link

mergify bot commented Sep 26, 2025

🧪 CI Insights

Here's what we observed from your CI run for c03d569.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.85%. Comparing base (f38dcf5) to head (c03d569).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/con_duct/__main__.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   91.32%   90.85%   -0.48%     
==========================================
  Files           7        7              
  Lines         945      951       +6     
  Branches      125      126       +1     
==========================================
+ Hits          863      864       +1     
- Misses         59       64       +5     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic added semver-patch Increment the patch version when merged good first issue Good for newcomers easy fix good-for-hackathon labels Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy fix good first issue Good for newcomers good-for-hackathon semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants