Skip to content

enh: Support duct config files #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 42 commits into from
Closed

enh: Support duct config files #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d7bd4d2
WIP: add duct config
asmacdo Sep 11, 2025
6d2f52d
add defaults as lowest precedence
asmacdo Sep 11, 2025
c897d5c
set CLI defaults to config-retrieved values
asmacdo Sep 11, 2025
afa86b1
move logging setup prior to config load
asmacdo Sep 11, 2025
93ea3f0
get CLI defaults from config
asmacdo Sep 11, 2025
5799ec9
fixup: rm overly defensive code
asmacdo Sep 11, 2025
2e2144b
fixup: cleanup extra comments
asmacdo Sep 11, 2025
939bdfd
add env vars/config for remaining CLI args
asmacdo Sep 11, 2025
e7a1b8f
add note for CLI defaults from config
asmacdo Sep 11, 2025
b2f6dfb
Config accepts multiple paths, and set default paths
asmacdo Sep 11, 2025
2eec931
Automatically add CLI argument env vars to help
asmacdo Sep 12, 2025
d3b45c4
fixup: rm logger test
asmacdo Sep 12, 2025
139ed02
cleanup extraneous dev code and comments
asmacdo Sep 12, 2025
f866bf2
Refactor: parse args in 1 pass, use FieldSpec
asmacdo Sep 15, 2025
dbd14c0
encapsulate config logic into class
asmacdo Sep 15, 2025
e4846bc
fixup: merge vars with underscores
asmacdo Sep 15, 2025
9be4925
add defaults and env vars to helptext
asmacdo Sep 15, 2025
2487575
fixup: rm opposite flagname for bools
asmacdo Sep 15, 2025
948e180
fixup unused var
asmacdo Sep 15, 2025
6b09f4f
fixup mv constant
asmacdo Sep 15, 2025
7e8a661
add --dump-config
asmacdo Sep 15, 2025
83d3c0a
add dummy positional args so --dump-config can be run naked
asmacdo Sep 15, 2025
d1fd060
move bool_from_str to validation area
asmacdo Sep 15, 2025
f06939c
remove unused positional arg.kind
asmacdo Sep 15, 2025
64ca251
rm silly 1line functions
asmacdo Sep 15, 2025
385ed17
simplify spec_default
asmacdo Sep 15, 2025
f46a5f8
dont truncate defaults, and escape special
asmacdo Sep 15, 2025
5fc7b29
asmacdo readthrough
asmacdo Sep 15, 2025
e9c3d9f
rm unnecessary var
asmacdo Sep 16, 2025
5f37afa
rm special case for config, not necessary since config not in field spec
asmacdo Sep 16, 2025
59cb612
tighten try:except
asmacdo Sep 16, 2025
75ffece
rm session_mode redirect
asmacdo Sep 16, 2025
faa051a
rm 1line/1use format code
asmacdo Sep 16, 2025
c95efbc
move config dump to function
asmacdo Sep 16, 2025
64733b4
fix test_arg_parsing and simplify enum args
asmacdo Sep 16, 2025
045f634
rm comments
asmacdo Sep 16, 2025
ac66b47
parameterize arg tests
asmacdo Sep 16, 2025
75e540b
Add basic config tests
asmacdo Sep 16, 2025
e363d8d
mv FIELD_SPECS after Config to use Config validations
asmacdo Sep 16, 2025
e17ed33
Config should be initializable without config paths
asmacdo Sep 16, 2025
6feec10
fixup configpaths precedence
asmacdo Sep 16, 2025
0fb8b2c
mock empty env vars to test default config values
asmacdo Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading