Fix: use mkdocs gh-deploy directly #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to install pems_data before mkdocs can build the mhausenblas/mkdocs-deploy-gh-pages action step seems to either ignore or not see that installation so make the actual deploy work more like the preview deploy, just install dependencies and use mkdocs directly
thekaveman
added
bug
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Preview url: https://pems-204--compiler-previews.netlify.app |
|
I ran the Deploy action manually against this branch, and the refactored deploy worked! https://github.com/compilerla/pems/actions/runs/16627376252 The docs site is live with our changes: https://docs.compiler.la/pems/development/pems_data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to install
pems_databeforemkdocscan build, since we autogenerate some of the docs from the Python docstrings (#196).The
mhausenblas/mkdocs-deploy-gh-pagesaction step seems to either ignore or not see that installation.So make the actual deploy work more like the preview deploy, just install dependencies and use
mkdocs gh-deploydirectly (which also builds the site).