-
Notifications
You must be signed in to change notification settings - Fork 112
Scene Data Store #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Licini
wants to merge
20
commits into
main
Choose a base branch
from
scene
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Scene Data Store #1461
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
58571a0
add scene object factory
Licini eff2b2e
add node_repr option to tree
Licini 3d5e493
use "data store" for Scene
Licini f07bdbf
Merge branch 'main' into scene
Licini 10e4225
finish the work, update tests
Licini e8b5fab
put back setter
Licini 82fa199
objectstore
Licini b730a4d
fixes
Licini 0c866d1
clean up the function
Licini 7ef3e4d
factory function instead of class
Licini 55dcfae
docstring
Licini 3e7a43d
get_sceneobject_node
Licini dd4344c
more clean up and test coverage
Licini 981464d
lint
Licini 85c3300
add coverage
Licini 44163d3
more tests
Licini ab5425a
lint
Licini 38a7d63
changelog
Licini ef4def8
clean up kwargs
Licini 01cf1af
naming pattern, type hints and changelog
Licini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These customizations are no longer needed anymore, thanks to the more straight forward serialization/deserialization