Migrate all Python3 Scripts to uv #4961
Draft
+979
−984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
high risk
vhsdream
reviewed
Jun 6, 2025
vhsdream
suggested changes
Jun 6, 2025
There was a problem hiding this comment.
For line 307-323 (immich-install.sh), this works:
cd "$SRC_DIR"/machine-learning
export VIRTUAL_ENV="${ML_DIR}/ml-venv"
$STD uv venv "$VIRTUAL_ENV"
if [[ -f ~/.openvino ]]; then
msg_info "Installing HW-accelerated machine-learning"
uv -q sync --extra openvino --no-cache --active
patchelf --clear-execstack "$ML_DIR"/ml-venv/lib/python3.11/site-packages/onnxruntime/capi/onnxruntime_pybind11_state.cpython-311-x86_64-linux-gnu.so
msg_ok "Installed HW-accelerated machine-learning"
else
msg_info "Installing machine-learning"
uv -q sync --extra cpu --no-cache --active
msg_ok "Installed machine-learning"
fiI've also found that the output of uv is not suppressed when using $STD, but using -q seems to do it, with the drawback that it will also suppress output during verbose operation.
Also, python3-dev (line 31) is required, otherwise the machine-learning build will fail
- Simplifies UV use in Immich install & update - Uses Python 3.11 (No official support for 3.12 yet) - Restores python3-dev package
2 tasks
|
I use this PR only for Tracking & Testing, every Script get His own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
projecttable found in:/opt/tandoor/pyproject.toml⠹ [ERROR] in line 63: exit code 0: while executing command $STD uv run python version.py🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.