VW PQ: Update Motor_3 & Getriebe_1 Signals #2724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DBC signals
car
|
didn't mean to push that into here but I'll just combine Motor_3 & Getriebe_1 PRs into one |
tealtwo
changed the title
tealtwo
changed the title
|
ready to merge |
Needs same rebase as your other PR. |
fixed, should be ready now |
gadhadar
pushed a commit
to qzwf/opendbc
that referenced
this pull request
Oct 14, 2025
* VW PQ: Correct Motor_3 Signals * VW PQ: update carstate for updated Motor_3 Signals in DBC * VW PQ: update comments to match updated signals in DBC * VW PQ: update safety test for updated DBC * VW PQ: update Getriebe_1 signal definitons * VW PQ: update Getriebe_1 signals * VW PQ: update values.py for updated Getriebe_1 signal definitons * Merge commaai/master --------- Co-authored-by: Jason Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updating the Motor_3 & Getriebe_1 signal definitions to have the correct signal names & add multiplexed signals (Motor_3) as they previously were not defined correctly, it is also updating the comments in the PQ safety mode to match PRs #2711, #2714, and this PR.