Skip to content

Conversation

tealtwo
Copy link
Contributor

@tealtwo tealtwo commented Sep 2, 2025

This PR aims to switch VW PQ to use HCA Status 7 (HCA7) instead of HCA Status 5 (HCA5), which would increase the available lateral torque usable by openpilot. HCA7 lacks the recentering force that constantly fights openpilot for lateral torque in HCA5. The lack of this recentering force increases the torque that openpilot can command. This change wasn’t previously merged due to issues controlling HCA7, but with the new MLSIM models, architecture updates, and OpenDBC refactor, many recent users (including myself) are running HCA7 and report it to be more stable and controllable & an increase in torque compared to HCA5.
This behavior should be present in stock openpilot as it gets rid of almost any torque warning or lack of torque on the highway & increases available torque for lower speed driving.
Validation

  • Route (Golf MK6): 4a824aa67cbfcd85/00000012--6672ca6b12
  • Route (NMS Passat): b3f9167062e09c61/0000008e--622dc1eab4
    more routes will be given if needed.

@tealtwo tealtwo marked this pull request as draft September 2, 2025 18:03
@github-actions github-actions bot added car related to opendbc/car/ volkswagen labels Sep 2, 2025
@jyoung8607
Copy link
Collaborator

Just to set expectations, I'm down with merging this if the data look good, but it's going to take a while to evaluate. I would have expected this to make the lateral accel torque controller behave oddly.

I see that some test routes have been provided. I'd like to see before/after with the same cars and same route driven.

@jyoung8607 jyoung8607 self-assigned this Sep 2, 2025
@tealtwo
Copy link
Contributor Author

tealtwo commented Sep 2, 2025

Just to set expectations, I'm down with merging this if the data look good, but it's going to take a while to evaluate. I would have expected this to make the lateral accel torque controller behave oddly.

I see that some test routes have been provided. I'd like to see before/after with the same cars and same route driven.

just to be clear, routes with the same vehicles running HCA5, and then HCA7 correct? I will publish the routes as soon as I get them

@tealtwo
Copy link
Contributor Author

tealtwo commented Sep 3, 2025

Just to set expectations, I'm down with merging this if the data look good, but it's going to take a while to evaluate. I would have expected this to make the lateral accel torque controller behave oddly.

I see that some test routes have been provided. I'd like to see before/after with the same cars and same route driven.

MK6 HCA5 route: 4a824aa67cbfcd85/0000001c--e45fa436f1

@tealtwo
Copy link
Contributor Author

tealtwo commented Sep 5, 2025

Just to set expectations, I'm down with merging this if the data look good, but it's going to take a while to evaluate. I would have expected this to make the lateral accel torque controller behave oddly.
I see that some test routes have been provided. I'd like to see before/after with the same cars and same route driven.

NMS Passat HCA5 Route: b3f9167062e09c61/000000a6--c5dcb34484/8 (segments 7-11)

@github-actions github-actions bot added the car safety vehicle-specific safety code label Oct 2, 2025
@tealtwo
Copy link
Contributor Author

tealtwo commented Oct 2, 2025

Given the previous discussion regarding HCA7, are we ready to merge?

@tealtwo tealtwo marked this pull request as ready for review October 2, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code car related to opendbc/car/ volkswagen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants