-
-
Notifications
You must be signed in to change notification settings - Fork 420
Android: Add nonTransitiveRClasses Option #5980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Add nonTransitiveRClasses Option #5980
Conversation
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
Can we have a comparison of the difference? E.g. a line count for the file input on the aapt2 compile or/and linking for each configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have androidDirectCompiledResources
and androidTransitiveCompiledResources
. The latter is a super-set of the former.
I was thinking, if it makes sense to have two disjunct sets, meaning, the transitive set contains only those resources not already in the direct resources? That way, we could easily spot what resources we potentially miss with mill show _.androidTransitiveCompiledResources
. But it also makes reasoning a bit easier, since the direct resources are always used. Meaning, we have a more stable task dependency tree.
#5862
This feature affects multi-module android applications. This blog helps on understanding its benefits.
The basic idea is compilation avoidance: in a dependency tree that’s at least three levels deep, modifying a node causes only that node and its parent to recompile, instead of propagating all the way up to the root.
(Test Branch)
Default value is set to true, like AGP>=8