Skip to content

Fix incorrect prepareOffline in AssemblyModule #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix incorrect prepareOffline in AssemblyModule #5521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fba2f
Fix incorrect prepareOffline in AssemblyModule
unlsycn Jul 13, 2025
78fc024
Update golden tests
unlsycn Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration/feature/inspect/src/InspectTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ object InspectTests extends UtestIntegrationTestSuite {
| mill.javalib.bsp.BspModule
| mill.javalib.RunModule
| mill.javalib.GenIdeaModule
| mill.javalib.OfflineSupportModule
| mill.javalib.SemanticDbJavaModule
| mill.javalib.AssemblyModule
| mill.javalib.JavaModule
Expand All @@ -171,7 +170,6 @@ object InspectTests extends UtestIntegrationTestSuite {
| mill.javalib.bsp.BspModule
| mill.javalib.RunModule
| mill.javalib.GenIdeaModule
| mill.javalib.OfflineSupportModule
| mill.javalib.SemanticDbJavaModule
| mill.javalib.AssemblyModule
| mill.javalib.JavaModule
Expand Down
7 changes: 6 additions & 1 deletion libs/javalib/src/mill/javalib/AssemblyModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import mill.util.Jvm
/**
* Module that provides functionality around creating and configuring JVM assembly jars
*/
trait AssemblyModule extends mill.api.Module {
trait AssemblyModule extends mill.api.Module with OfflineSupportModule {
outer =>

def finalMainClassOpt: T[Either[String, String]]
Expand Down Expand Up @@ -148,6 +148,11 @@ trait AssemblyModule extends mill.api.Module {
created.pathRef
}
}

override def prepareOffline(all: mainargs.Flag): Task.Command[Seq[PathRef]] = Task.Command {
AssemblyModule.prepareOffline(all)()
}

}
object AssemblyModule extends ExternalModule with CoursierModule with OfflineSupportModule {

Expand Down
Loading