PR: Prefer complex64 and complex128 over csingle and cdouble.
#1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KelSolaar
changed the title
complex64 and complex128 over csingle and cdoublecomplex64 and complex128 over csingle and cdouble.
KelSolaar
changed the base branch from
develop
to
feature/scalar-type-aliases-staging
KelSolaar
merged commit b43588c
into
colour-science:feature/scalar-type-aliases-staging
13 of 16 checks passed
|
Thanks @jorenham! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
numpy>=2.1, thefloat64andcomplex128scalar types differ fromdoubleandcdouble(see numpy/numpy#29151 for details and numpy/numpy#29155 for the fix). The sized types are (almost always) preferred. And usually, that's already done here. But this case what a bit of an exception, so I corrected it.