Refactor out the OBS interaction code into a new obs-commander crate #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi64
force-pushed
the
wip/refi64/commander
branch
from
91ce9dc to
69cde70
Compare
refi64
force-pushed
the
wip/refi64/commander
branch
from
69cde70 to
ccfe422
Compare
refi64
force-pushed
the
wip/refi64/commander
branch
2 times, most recently
from
398d532 to
db60b97
Compare
refi64
force-pushed
the
wip/refi64/commander
branch
2 times, most recently
from
b1fe33f to
e2380c7
Compare
refi64
force-pushed
the
wip/refi64/commander
branch
2 times, most recently
from
d6afbc4 to
3fbef6d
Compare
Passing around `self` risks confusing the borrow checker if we need to invoke a method on a field, and it's rather confusing to begin with.
All the generic command handling is now part of an `actions` module, and logging happens through a rather cursed magic bridge in the new `logging` module to remove the widespread use of outputln.
This is largely just a rename, as well as the slightly-silly `obs-commander-test-support` crate that exists to avoid making the primary `obs-commander` crate depend on testing dependencies.
refi64
force-pushed
the
wip/refi64/commander
branch
from
3fbef6d to
fec53d4
Compare
| let (mut file, len) = retry_request!({ | ||
| artifacts | ||
| .save_with(filename, async |file: &mut ArtifactWriter| { | ||
| file.rewind().await.wrap_err("Failed to rewind build log")?; |
| [workspace] | ||
| resolver = "3" | ||
| members = [ | ||
| "obs-commander", |
There was a problem hiding this comment.
commands please ; it's obs not the military
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #52 and the rest of the stack. Only relevant part is the last commit.