Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I recently had a requirement to extend the redis cache module to support automatic failover to another server, I've implemented this via the phpredis module, and thusly have a check wrapped around the code to make sure this exists in the php build. Main reason for this direction is I didn't have the time to learn how it works, and any overheads that would be tied to instantiating the credis_client class twice for the check. This code does add an additional overhead, so it should really only be turned on if it is needed.
Thanks!